Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: revise typo in korean README and common CONTRIBUTING readme #2160

Merged
merged 2 commits into from
Nov 13, 2023
Merged

docs: revise typo in korean README and common CONTRIBUTING readme #2160

merged 2 commits into from
Nov 13, 2023

Conversation

young-hun-jo
Copy link
Contributor

@young-hun-jo young-hun-jo commented Nov 12, 2023 •
edited
Loading

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

  • Documentation(korean)
  • Documentation(CONTRIBUTING.md)

Description

  • revise spacing typo in korean readme by (@starcat37 , PR)
  • revise typo in CONTRIBUTING.md
    • I follow guideline for making PR but I found lower bound of unit-test 80%, but I found CLI log in my terminal following guideline(plz check attachment). please check it

스크린샷 2023-11-12 오후 11 06 42

@young-hun-jo young-hun-jo changed the title docs: revise typo in korean REAMDE and common CONTRIBUTING readme docs: revise typo in korean README and common CONTRIBUTING readme Nov 12, 2023
picklelo
picklelo approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@picklelo picklelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@picklelo picklelo merged commit 8b93586 into reflex-dev:main Nov 13, 2023
1 check passed
@young-hun-jo young-hun-jo deleted the docs/korean branch November 17, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@young-hun-jo @picklelo