-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement accordion component #2262
Conversation
@@ -1,4 +1,5 @@ | |||
{% import 'web/pages/utils.js.jinja2' as utils %} | |||
/** @jsxImportSource @emotion/react */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why, but in my app this is rendering as
/** @jsxImportSource @emotion/react */import { Fragment } from "react"
It still seems to work, somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not sure I added an extra blank line but doesn't seem to care
a290242
to
b8c2084
Compare
reflex/style.py
Outdated
@@ -48,7 +48,7 @@ def convert(style_dict): | |||
var_data = None # Track import/hook data from any Vars in the style dict. | |||
out = {} | |||
for key, value in style_dict.items(): | |||
key = format.to_camel_case(key) | |||
key = format.to_camel_case(key, allow_hyphens=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this intending to support? this breaks the code that i was working on to support things like ::-webkit-scrollbar
as pseudo elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed this for certain aria-label
props, that were getting converted automatically toariaLabel
and messing it up. I'll see if I can remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undid this change
style: Style = Style( | ||
{ | ||
"fontFamily": "inherit", | ||
"backgroundColor": "white", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should use a theme color here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it "transparent" though I think actually it should be using one of the gray colors (either white or black). We can update this with the themes PR
@@ -195,6 +196,10 @@ class Cartesian(Recharts): | |||
# The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none'optional | |||
# legend_type: Var[LiteralLegendType] | |||
|
|||
def _apply_theme(self, theme: Component): | |||
self.stroke = Var.create(f"var(--accent-8)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to be working... when i change the accent color, it does not affect the charts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the graphing changes for now
Test code: