Revert "Revert "use process pool to compile faster (#2377)" (#2434)" #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
approved these changes
Jan 31, 2024
jackie-pc
added a commit
that referenced
this pull request
Feb 13, 2024
picklelo
pushed a commit
that referenced
this pull request
Feb 13, 2024
masenf
added a commit
that referenced
this pull request
Mar 5, 2024
masenf
added a commit
that referenced
this pull request
Mar 12, 2024
masenf
added a commit
that referenced
this pull request
Mar 13, 2024
masenf
added a commit
that referenced
this pull request
Mar 16, 2024
* Revert "Revert "Revert "Revert "use process pool to compile faster (#2377)" (#2434)" (#2497)" (#2595)" This reverts commit 6b6eea4. * Adjust number of operations for more correct progress bar * app: recognize REFLEX_COMPILE_PROCESSES and REFLEX_COMPILE_THREADS Control whether multiprocessing is used and the number of processes or threads that should be used. This will allow users to opt-in to the new, potentially hazardous, multiprocessing mode, which results in much faster compiles, but has already been reverted 4 times. Lets leave the code in this time, but use the thread pool executor by default. Limiting the number of threads or processes to 1 can also aid in debugging issues that arise during compile time. * Allow REFLEX_COMPILE_PROCESSES=0 to trigger multiprocessing with auto workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring this back into main so we can dogfood / trigger potential issues with shutdown x subprocess terminations