[REF-2122] Opt-in multiprocess compile #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picklelo
previously approved these changes
Mar 13, 2024
Control whether multiprocessing is used and the number of processes or threads that should be used. This will allow users to opt-in to the new, potentially hazardous, multiprocessing mode, which results in much faster compiles, but has already been reverted 4 times. Lets leave the code in this time, but use the thread pool executor by default. Limiting the number of threads or processes to 1 can also aid in debugging issues that arise during compile time.
masenf
force-pushed
the
masenf/multiprocess-compile-try-again
branch
from
8a6064b
to
51bf447
Compare
picklelo
approved these changes
Mar 16, 2024
|
Personally I'd like to see if more modularized and pluggable, at least the parts we parallelize, because obviously the order does not matter for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2810
Pass the environment variable
REFLEX_COMPILE_PROCESSES=0to enable multiprocessing compilation engine. Pass a number other than zero to control the number of processes to spawn.It's also possible to set
REFLEX_COMPILE_THREADS=Xwhere X is the number of threads to use, and zero (the default) means automatic.The default behavior here is to continue using the ThreadPoolExecutor as the default engine. It's not as fast as multiprocessing, but since 4 previous revisions of this code have been reverted, I'm sticking with a safe default until we can get more real world testing... but no one is going to test it in a side branch, so we need to get it into main and enable it during out development processes to try to tease out any issues.
Exposing the controls this way also allows us to more easily tune and tweak the implementation without having to edit the code directly.