[REF-2587] Ignore top-level theme appearance #3119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Radix docs, it is not recommended to actually set
appearance
, but instead use next-themes to set and switch the appearance dynamically.Because Reflex already compiles the top-level theme into the next-themes ThemeProvider, we can blank out the appearance prop after compiling contexts.js to avoid a mismatch between the selected app appearance and the appearance in the rx.theme when displaying overlay components.
Fix #2992
Bonus: fix the pyi_generator with pre-commit to stop creating .pyi files for those in the EXCLUDED_FILES list
Sample code