Fixed unused kwargs in reflex.App #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
previously approved these changes
Apr 26, 2024
masenf
requested changes
Apr 26, 2024
There was a problem hiding this comment.
Thanks for the contribution and tracking down that mysterious bug!
I have a couple of suggestions to improve the patch. The team has been wondering if exposing the sio externally is a good idea (yes it was documented, via generated docs), or if we should just expose the parameters as configuration knobs, like cors_allowed_origins.
For now, I'm leaning toward allowing the user to supply their own AsyncServer object.
|
Updated patch in commit. Made |
masenf
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Fixed kwargs
sioandsocket_appare not used during reflex.App initializationCloses #3081