[REF-2676][REF-2751]Windows Skip ARM devices on bun install + Telemetry #3212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElijahAhianyo
changed the title
ElijahAhianyo
changed the title
masenf
previously approved these changes
May 2, 2024
| Returns: | ||
| Whether the host is qualified to use bun. | ||
| """ | ||
| cpu_info = get_cpu_info() |
There was a problem hiding this comment.
i think we should wrap this in a try/except; reflex shouldn't fail to work just because a user's system doesn't have lscpu or the address width isn't castable as an int for whatever reason.
There was a problem hiding this comment.
Got it, pushed a fix for this
picklelo
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used
python.machine()to get the cpu architecture of the underlining host, but since the architecture produced by python is only that of the executable python binary installed on the host, it may not correlate with the actual architecture of the host. A classic eg. Is Installing thex86_64version of python on an ARM device. This causes reflex to install bun which later fails when installing frontend packages and then fall back to npm.In this PR, we use
wmicon Windows to get accurate info on the host CPU architecture, which should skip bun installation completely on ARM and 32-bit devices.In addition to this PR, we're collecting more telemetry data on the OS(previously we only collected the OS name without the version and build) and CPU; model, manufacturer or vendor ID and address width (whether the underlining host is
32or64 bit). This should aid us and give us a fair idea in the future where/when necessary during development, the nature of devices users run.fixes #3151