-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update blank template #3219
update blank template #3219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the content supposed to be left aligned now? i actually think it looks kinda cool that way.
The other issue is in chrome there is always a scroll bar now, regardless of the window height (on my screen anyway). min_height="88vh"
or something a bit smaller might help there.
That's the intention yeah. I can tweak the value for min_height yeah, didn't happens on my screen. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're touching this, can we rearrange the imports too?
I'd rather see
import reflex as rx
from rxconfig import config
filename = f"{config.app_name}/{config.app_name}.py"
- this is the preferred pep8-style import order, local modules should be listed after installed modules
- this makes it easier to delete without removing the reflex import
i also think we should just inline the docs_url
, instead of defining it at the top of the module
I tried, but we literally can't, because reflex is considered as a local, ruff change the import back to how they are at the moment. |
@Lendemor maybe you can add a ruff config overwrite for the template dir: https://docs.astral.sh/ruff/configuration/#config-file-discovery maybe smth like this (untested): [tool.ruff]
# Extend the `pyproject.toml` file in the parent directory...
extend = "../pyproject.toml"
[tool.ruff.isort]
known-first-party = [] |
Thanks for the suggestion, we went with excluding the rule |
No description provided.