Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF-2622]Throw warning for incompatible uvicorn version on windows #3246

Merged
merged 2 commits into from
May 8, 2024

Conversation

ElijahAhianyo
Copy link
Collaborator

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

New Feature Submission:

  • Does your submission pass the tests?
  • Have you linted your code locally prior to submission?

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@ElijahAhianyo ElijahAhianyo marked this pull request as ready for review May 7, 2024 20:12
@ElijahAhianyo ElijahAhianyo changed the title Throw warning for incompatible uvicorn version on windows [REF-2622]Throw warning for incompatible uvicorn version on windows May 7, 2024
Copy link

linear bot commented May 7, 2024

@picklelo picklelo merged commit 1d09348 into main May 8, 2024
46 checks passed
@picklelo picklelo deleted the elijah/uvicorn-version-warn branch August 21, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants