Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in contact email address #3292

Merged
merged 1 commit into from
May 13, 2024
Merged

Typo in contact email address #3292

merged 1 commit into from
May 13, 2024

Conversation

ericwb
Copy link
Contributor

@ericwb ericwb commented May 13, 2024

The demo template includes a drop down menu item named Contact has an email address to the founders. However, the email address includes an extraneous = character in the domain part making it invalid.

All Submissions:

  • Have you followed the guidelines stated in CONTRIBUTING.md file?
  • Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Changes To Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

a. Give a descriptive title to your PR.

b. Describe your changes.

c. Put `closes #XXXX` in your comment to auto-close the issue that your PR fixes (if such).

@ericwb
Typo in contact email address
26a6c0f 
The demo template includes a drop down menu item named Contact
has an email address to the founders. However, the email address
includes an extraneous = character in the domain part making it
invalid.

Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
masenf
masenf approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixup

@masenf masenf merged commit bff4464 into reflex-dev:main May 13, 2024
46 checks passed
masenf pushed a commit that referenced this pull request May 13, 2024
@ericwb @masenf
Typo in contact email address (#3292)
5e1fe07 
The demo template includes a drop down menu item named Contact
has an email address to the founders. However, the email address
includes an extraneous = character in the domain part making it
invalid.

Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request May 16, 2024
@ericwb @benedikt-bartscher
Typo in contact email address (reflex-dev#3292)
2853cda 
The demo template includes a drop down menu item named Contact
has an email address to the founders. However, the email address
includes an extraneous = character in the domain part making it
invalid.

Signed-off-by: Eric Brown <eric_wade_brown@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericwb @masenf