Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated radio group component #3474

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

sagarhedaoo
Copy link
Contributor

@sagarhedaoo sagarhedaoo commented Jun 11, 2024

All Submissions:

  • [Yes] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [Yes] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

New Feature Submission:

  • [Yes] Does your submission pass the tests?
  • [Yes] Have you linted your code locally prior to submission?
    I have temporarily commented the ruff-pre-commit through the config.yaml because it was not allowing me to commit.

After these steps, you're ready to open a pull request.

closes #3413

- id: ruff
args: ["--fix", "--exit-non-zero-on-fix"]
exclude: '^integration/benchmarks/'
# - repo: https://github.com/charliermarsh/ruff-pre-commit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be commented out.

If you want to commit and skip pre-commit, use the --no-verify flag.

Note that you'll still need to pass the CI.

@picklelo picklelo merged commit 6fdc5a8 into reflex-dev:main Jun 17, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap Radio Group Radix (New Component)
3 participants