New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce customizable breakpoints #3568

Merged

adhami3310 merged 7 commits into reflex-dev:main from adhami3310:responsive-breakpoints

Jun 26, 2024

Member

adhami3310 commented Jun 25, 2024

All Submissions:

Have you followed the guidelines stated in CONTRIBUTING.md file?
[ x Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

New feature (non-breaking change which adds functionality)

New Feature Submission:

Does your submission pass the tests?
Have you linted your code locally prior to submission?


          introduce customizable breakpoints

b74634d

adhami3310 requested a review from masenf

June 25, 2024 23:28

adhami3310 added 4 commits

June 26, 2024 02:45


          fix docstrings

70d09f7


          modify breakpoints to the original values

b0e9bb2


          use older tuple typing

ec28d43


          use optional rather than union

5d2092d

Member Author

adhami3310 commented Jun 26, 2024

It's possible to be more strict in typings and validation, let me know if any is needed.

masenf previously approved these changes

View reviewed changes

reflex/components/core/breakpoints.py Outdated Show resolved Hide resolved

Collaborator

masenf commented Jun 26, 2024

in testing, i actually noticed that rx.breakpoints is not recognized in vscode, i think for whatever reason the reflex/__init__.pyi did not get regenerated.

i tried running poetry run python scripts/make_pyi.py reflex/__init__.py myself, but i don't actually see a diff in reflex/__init__.pyi 🤔 seems like there is something wrong with the pyi generator, i'll look into it

picklelo previously requested changes

View reviewed changes

Contributor

picklelo left a comment

Let's try to move the parameter into the Style class and I think this is good.

reflex/style.py Show resolved Hide resolved

reflex/components/core/breakpoints.py Show resolved Hide resolved


          remove unnecessary __init__

125a48e

adhami3310 dismissed masenf’s stale review via

125a48e

June 26, 2024 17:28


          add style field

2fb1893

adhami3310 dismissed picklelo’s stale review

June 26, 2024 20:24

fixed in #2fb1893

adhami3310 requested a review from masenf

June 26, 2024 20:59

picklelo approved these changes

View reviewed changes

Contributor

picklelo left a comment

Looks good to me!

adhami3310 merged commit 82a0d7f into reflex-dev:main

47 checks passed

adhami3310 deleted the responsive-breakpoints branch

June 26, 2024 22:34

cutoffthetop referenced this pull request in robert-koch-institut/mex-editor


          Update dependency reflex to v0.5.6 (#106)

77b4fe8

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [reflex](https://reflex.dev)
([source](https://togithub.com/reflex-dev/reflex)) |
project.dependencies | patch | `==0.5.5` -> `==0.5.6` |

---

### Release Notes

<details>
<summary>reflex-dev/reflex (reflex)</summary>

###
[`v0.5.6`](https://togithub.com/reflex-dev/reflex/releases/tag/v0.5.6)

[Compare
Source](https://togithub.com/reflex-dev/reflex/compare/v0.5.5...v0.5.6)

#### New Features

##### `rx.clipboard`

Handle global and component-scoped `on_paste` with multi-type data

- Add Clipboard component for handling global on_paste event by
[@&#8203;masenf](https://togithub.com/masenf) in
[https://github.com/reflex-dev/reflex/pull/3513](https://togithub.com/reflex-dev/reflex/pull/3513)

##### `rx.breakpoints` - Set breakpoints by name

- introduce customizable breakpoints by
[@&#8203;adhami3310](https://togithub.com/adhami3310) in
[https://github.com/reflex-dev/reflex/pull/3568](https://togithub.com/reflex-dev/reflex/pull/3568)
- add responsive props to radix components by
[@&#8203;adhami3310](https://togithub.com/adhami3310) in
[https://github.com/reflex-dev/reflex/pull/3583](https://togithub.com/reflex-dev/reflex/pull/3583)

##### Computed Backend Vars

- add computed backend vars by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3573](https://togithub.com/reflex-dev/reflex/pull/3573)
- improve backend var determination by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3587](https://togithub.com/reflex-dev/reflex/pull/3587)

#### Improvements

- \[REF-3056]Config knob for redis StateManager expiration times by
[@&#8203;ElijahAhianyo](https://togithub.com/ElijahAhianyo) in
[https://github.com/reflex-dev/reflex/pull/3523](https://togithub.com/reflex-dev/reflex/pull/3523)
- \[Perf] Ensure rx.match gets memoized to avoid excessive re-rendering
by [@&#8203;masenf](https://togithub.com/masenf) in
[https://github.com/reflex-dev/reflex/pull/3552](https://togithub.com/reflex-dev/reflex/pull/3552)
- bare sqlalchemy session + tests by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3522](https://togithub.com/reflex-dev/reflex/pull/3522)
- Remove chakra from codeblock by
[@&#8203;abulvenz](https://togithub.com/abulvenz) in
[https://github.com/reflex-dev/reflex/pull/3570](https://togithub.com/reflex-dev/reflex/pull/3570)
- add compilation timestamp in log by
[@&#8203;Lendemor](https://togithub.com/Lendemor) in
[https://github.com/reflex-dev/reflex/pull/3563](https://togithub.com/reflex-dev/reflex/pull/3563)
- \[REF-3148] add props for tabs by
[@&#8203;Lendemor](https://togithub.com/Lendemor) in
[https://github.com/reflex-dev/reflex/pull/3560](https://togithub.com/reflex-dev/reflex/pull/3560)
- show the value causing problem in deprecation warning by
[@&#8203;Lendemor](https://togithub.com/Lendemor) in
[https://github.com/reflex-dev/reflex/pull/3558](https://togithub.com/reflex-dev/reflex/pull/3558)
-   Better support for Github Codespaces
- Add a link to backend in connection error by
[@&#8203;masenf](https://togithub.com/masenf) in
[https://github.com/reflex-dev/reflex/pull/3044](https://togithub.com/reflex-dev/reflex/pull/3044)
- Better hot reload times on Windows with python 3.12 and uvicorn > 0.20
- \[REF-3164] Hack to fix Windows hot reload + Uvicorn upgrade by
[@&#8203;masenf](https://togithub.com/masenf) in
[https://github.com/reflex-dev/reflex/pull/3584](https://togithub.com/reflex-dev/reflex/pull/3584)
-   `rx.theme` appearance is reset in dev mode
- \[REF-2588]Clear color mode local storage for dev mode by
[@&#8203;ElijahAhianyo](https://togithub.com/ElijahAhianyo) in
[https://github.com/reflex-dev/reflex/pull/3548](https://togithub.com/reflex-dev/reflex/pull/3548)

#### Bug Fixes

- Fix radix radio cards component by
[@&#8203;emmakodes](https://togithub.com/emmakodes) in
[https://github.com/reflex-dev/reflex/pull/3545](https://togithub.com/reflex-dev/reflex/pull/3545)
- fix small typing issue by
[@&#8203;Lendemor](https://togithub.com/Lendemor) in
[https://github.com/reflex-dev/reflex/pull/3562](https://togithub.com/reflex-dev/reflex/pull/3562)
- \[REF-3185]\[REF-3180]Dont escape backticks in JS string interpolation
by [@&#8203;ElijahAhianyo](https://togithub.com/ElijahAhianyo) in
[https://github.com/reflex-dev/reflex/pull/3566](https://togithub.com/reflex-dev/reflex/pull/3566)
- classvars should not be backend vars by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3578](https://togithub.com/reflex-dev/reflex/pull/3578)
-   ComponentState and State mixins now work with backend vars
- copy backend vars from mixins by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3580](https://togithub.com/reflex-dev/reflex/pull/3580)
- fix var dependency over properties by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3588](https://togithub.com/reflex-dev/reflex/pull/3588)
- \[REF-3157] Avoid SQLModel metaclass conflict
([#&#8203;3610](https://togithub.com/reflex-dev/reflex/issues/3610))
- \[REF-3220] Fix rx.cancel_upload EventSpec
([#&#8203;3608](https://togithub.com/reflex-dev/reflex/issues/3608))
- do not get_config in global scope
([#&#8203;3597](https://togithub.com/reflex-dev/reflex/issues/3597))

#### Other Changes

- Validate ComputedVar dependencies, add tests by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3527](https://togithub.com/reflex-dev/reflex/pull/3527)
- do not validate non-cached var deps by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3576](https://togithub.com/reflex-dev/reflex/pull/3576)
- Radio group fix deprecation warning for creating vars with strings by
[@&#8203;ElijahAhianyo](https://togithub.com/ElijahAhianyo) in
[https://github.com/reflex-dev/reflex/pull/3567](https://togithub.com/reflex-dev/reflex/pull/3567)
- update dependencies pinning by
[@&#8203;Lendemor](https://togithub.com/Lendemor) in
[https://github.com/reflex-dev/reflex/pull/3556](https://togithub.com/reflex-dev/reflex/pull/3556)
- fix formatting by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3574](https://togithub.com/reflex-dev/reflex/pull/3574)
- order type annotations in pyi_generator by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3585](https://togithub.com/reflex-dev/reflex/pull/3585)
- Deprecate cached var by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3582](https://togithub.com/reflex-dev/reflex/pull/3582)
- Change Strategy Prop to Literal by
[@&#8203;Alek99](https://togithub.com/Alek99) in
[https://github.com/reflex-dev/reflex/pull/3575](https://togithub.com/reflex-dev/reflex/pull/3575)
- pyi_generator cleanup: ruff, remove fully qualified reflex. names by
[@&#8203;masenf](https://togithub.com/masenf) in
[https://github.com/reflex-dev/reflex/pull/3591](https://togithub.com/reflex-dev/reflex/pull/3591)
- cleanup unused check by
[@&#8203;benedikt-bartscher](https://togithub.com/benedikt-bartscher) in
[https://github.com/reflex-dev/reflex/pull/3590](https://togithub.com/reflex-dev/reflex/pull/3590)
- split lifespan and middleware logic in separate mixin files by
[@&#8203;Lendemor](https://togithub.com/Lendemor) in
[https://github.com/reflex-dev/reflex/pull/3557](https://togithub.com/reflex-dev/reflex/pull/3557)
- Update links to /docs/library/dynamic-rendering/foreach/
([#&#8203;3609](https://togithub.com/reflex-dev/reflex/issues/3609))

#### New Contributors

##### Welcome Khaleel to the Core Team

- [@&#8203;adhami3310](https://togithub.com/adhami3310) made their first
contribution in
[https://github.com/reflex-dev/reflex/pull/3568](https://togithub.com/reflex-dev/reflex/pull/3568)

**Full Changelog**:
reflex-dev/reflex@v0.5.5...v0.5.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet