Fix the error boundary #3637
Merged
Fix the error boundary #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rx.App - wrapped the app with ErrorBoundary component to catch rendering errors
- minor refactoring of error boundary - removed error boundary from 404 page
* Remove custom _render function * Remove special imports in Component base class * Simplify hooks for better composability
masenf
approved these changes
Jul 9, 2024
Alek99
pushed a commit
that referenced
this pull request
Jul 15, 2024
* - added possibility to pass front- and backend exception handlers to rx.App - wrapped the app with ErrorBoundary component to catch rendering errors * added missing exception handler to reflex.app._process * regenerated pyi * fix unit tests for exception handler validation * fix typing error in ErrorBoudary * - fix error_bounday pyi - minor refactoring of error boundary - removed error boundary from 404 page * added missing inspect module import after merging main * fix typing error * Clean up ErrorBoundary component * Remove custom _render function * Remove special imports in Component base class * Simplify hooks for better composability * test_exception_handlers: also test in prod mode * fixed color prop * fixed error boundary bug and removed hardcoding of the frontend event exception state * formatted the code after conflict resolution * fixed type of the error_boundary * ruff format --------- Co-authored-by: Maxim Vlah <m.vlah@senbax.de> Co-authored-by: Masen Furer <m_github@0x26.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ErrorBoundarycomponent would always be rendered even if we pass a custom one. Seereflex/reflex/app.py
Line 754 in 9e1789a
FrontendEventExceptionStatename across multiple files with a single constant in the repo to avoid mistakes (based on Add the possibility to pass custom front- and backend event exception handlers to the rx.App #3476 (comment))