Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove format_state and override behavior for bare #3979

Merged
merged 8 commits into from
Sep 26, 2024
Merged

remove format_state and override behavior for bare #3979

merged 8 commits into from
Sep 26, 2024
+30 −117

Conversation

adhami3310
Copy link
Member

No description provided.

@linear Linear
Copy link

linear bot commented Sep 23, 2024

ENG-3827 Objects are not allowed as React children

masenf
masenf reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we can now also remove serialize_list and serialize_dict

masenf
masenf approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

red diff ftw

tests/units/utils/test_format.py Show resolved Hide resolved
@adhami3310 adhami3310 merged commit 0ab161c into main Sep 26, 2024
39 checks passed
@masenf masenf mentioned this pull request Sep 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adhami3310 @masenf