new ClientHellos and Extensions #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certificate compression is defined in RFC 8879: https://datatracker.ietf.org/doc/html/rfc8879 This implementation is client-side only, for server certificates.
…4372a99cb162eb70e8d5f - At this commit, github.com/Noooste/utls remained at the original upstream LICENSE
gaukas
reviewed
Sep 7, 2022
| @@ -79,7 +79,7 @@ func (e *SNIExtension) Read(b []byte) (int, error) { | |||
| b[0] = byte(extensionServerName >> 8) | |||
| b[1] = byte(extensionServerName) | |||
| b[2] = byte((len(hostName) + 5) >> 8) | |||
| b[3] = byte((len(hostName) + 5)) | |||
| b[3] = byte(len(hostName) + 5) | |||
|
Thank you @rp-psiphon, and also thanks to @Psiphon-Labs, @rod-hynes, @sleeyax and @Noooste! |
dyhkwong
reviewed
Oct 13, 2022
| pointFormatUncompressed, | ||
| }}, | ||
| &SessionTicketExtension{}, | ||
| &ALPNExtension{AlpnProtocols: []string{"h2", "http/1.1"}}, | ||
| &ALPNExtension{AlpnProtocols: []string{"h2"}}, //application_layer_protocol_negotiation |
There was a problem hiding this comment.
HelloFirefox_102 here should have ALPN {"h2", "http/1.1"} https://tlsfingerprint.io/compare/7161e10829541aab/b250617dca0ac79f
There was a problem hiding this comment.
Interesting. According to TLSfingerprint.io, the current fingerprint with only h2 is also a fingerprint of Firefox 102.
But I agree that we may want to move toward one with better compatibility.
There was a problem hiding this comment.
On a second thought, I decide not to change it. Since we have Firefox 105 which is essentially b250617dca0ac79f, we want to preserve the variety.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various ClientHellos and TLS extensions are included in this PR, from Psiphon-Labs , Noooste, and sleeyax.
Fingerprints and extensions were tested by comparing Wireshark captures from our ClientHellos to captures from real browsers (and the extensions being used).
Psiphon-Labs :
sleeyax:
Noooste: