feat: Convert raw bytes or tlsfingerprint record to ClientHelloSpec #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will automatically add "h2" to ALPS and write to log when GREASE extension is imported in `ImportTLSClientHello()`
ReadCompressionMethods didn't advance the s and fails reading extensions
`helper.Uint8to16()` now calls `(*cryptobyte.String).ReadUint16()`
updated fingerprinter test to test with PreSharedKey extension
It is a Fake extension since `crypto/tls` doesn't really implement PSK-based resumption and neither do we.
Adopted from #148. Co-Authored-By: gfw-report <gfw.report@protonmail.com>
And reordered `fakeExtensionDelegatedCredentials`. The new `Fingerprinter` is expected to account for the `fakeExtensionEncryptThenMAC` using a `GenericExtension` when `allowBluntMimicry` is set. Co-Authored-By: gfw-report <gfw.report@protonmail.com>
ewust
reviewed
Mar 9, 2023
- Removed all presence of keepPSK flag. - Added check before using the field of a map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially implements #164.
ClientHelloSpec(revisitedFingerprinter)ClientHelloSpec(see https://client.tlsfingerprint.io/ for example)ClientHelloSpecIntegrated commits/changes from #148 to prevent merge conflict on #148. Merging this PR should close #148.