Return better error messages and types for labeling errors #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -221,12 +226,27 @@ async def _alabel(self, prompts: List[str]) -> RefuelLLMResult: | |||
| ) | |||
| except Exception as e: | |||
| logger.exception(f"Unable to generate prediction: {e}") | |||
| error_message = str(e) | |||
There was a problem hiding this comment.
Added new error parsing logic for OpenAI here. If we want to land these changes, can also add similar logic for other providers.
nihit
approved these changes
Jun 12, 2024
Comment on lines
230
to
244
| except json.JSONDecodeError as e: | ||
| logger.error( | ||
| f"Invalid JSON in LLM response: {response.text}, Error: {e}" | ||
| ) | ||
| llm_label = self.NULL_LABEL | ||
| error = LabelingError( | ||
| error_type=ErrorType.PARSING_ERROR, | ||
| error_message=f"Unable to parse invalid JSON in LLM response.", | ||
| ) | ||
| except Exception as e: | ||
| logger.error(f"Error parsing LLM response: {response.text}, Error: {e}") | ||
| llm_label = self.NULL_LABEL | ||
| error = LabelingError( | ||
| error_type=ErrorType.PARSING_ERROR, error_message=str(e) | ||
| error_type=ErrorType.INVALID_LLM_RESPONSE_ERROR, | ||
| error_message=str(e), |
There was a problem hiding this comment.
let's simplify this - it's okay to keep the older logic:
- if any issue with json parsing, try to extract a valid json substring
- if any issue with this, just return an empty reponse and log it as ErrorType.INVALID_LLM_RESPONSE_ERROR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Review Summary
Description
Return better error messages and types for labeling errors by parsing LLM provider errors for appropriate error types when available. Still use default error types as fallback.
Type of change
Tests
Tested locally