Serp api query if input columns are empty #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajasbansal
requested review from
yadavsahil197,
Abhinav-Naikawadi and
nihit
and removed request for
yadavsahil197
| @@ -105,7 +105,9 @@ async def _apply(self, row: Dict[str, Any]) -> Dict[str, Any]: | |||
| logger.error( | |||
| f"Missing query column: {col} in row {row}", | |||
| ) | |||
| query = self.query_template.format_map(defaultdict(str, row)) | |||
| query = self.query_template.format_map( | |||
There was a problem hiding this comment.
can we also handle the case when all input columns are empty?
There was a problem hiding this comment.
what does that mean? The default dict changes all empty columns to ""
There was a problem hiding this comment.
I think perhaps we don't make query if no query columns present in row?
Abhinav-Naikawadi
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Review Summary
Description
Serp api query if input columns are empty. Currently, if the inputs are empty i.e None, we send the string None to google. We should probably change that to an empty string by explicitly filtering this dictionary
Type of change
Tests