Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for
SettingStore::LoadUserSettings
. Uses plugin file name asmodName
forReadINI
function instead of use INI file name.Some user reported that MCM doesn't read used config file when name of the config file doesn't exactly
match to name of plugin file. That is, when file names differ only in character case, MCM will not read user config. Proposed change searches for all plugin files and if there is user config file for this plugin, calls
SettingStore::ReadINI
with plugin file name asmodName
argument toReadINI
and not with user INI file.New loader code is written using some C++17 features, but can be easily rewritten to compile with older versions.
Sorry, seems like GitHub converted line endings in .cpp file.