fix gotoTrack after removeAllTracks, don't use sources[oi].audioPath #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, just tested on Chrome/Firefox/Safari (plus iPhone), and it works great! Merging... |
regosen
added a commit
that referenced
this pull request
Jan 24, 2016
fix gotoTrack after removeAllTracks, don't use sources[oi].audioPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gapless tries to load an "undefined" track if you do a gotoTrack after resetAllTracks(). This is fixed by grabbing the audioPath not from the sources object, but from the tracks array in the player object.
I'm testing this on my internal gapless jukeboxes and it appears to work without issues, but any brain/eyes behind making sure this change does the right thing is appreciated :)