player: Avoid getting properties from unavailable player #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pespin
force-pushed
the
pespin/fix
branch
2 times, most recently
from
b600a6e
to
3b13573
Compare
It makes no sense asking for playerid=1 if it doesn't exist.
Furthermore, it makes Kodi return:
"""
{"error":{"code":-32100,"message":"Failed to execute method."},"id":2,"jsonrpc":"2.0"}
"""
which makes the entire context menu fail and show only an error.
Fixes: regseb#34
|
Hi, any feedback on this (and related ticket)? I would like to get this merged ASAP since it prevents me from using kodi sometimes. |
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes no sense asking for playerid=1 if it doesn't exist.
Furthermore, it makes Kodi return:
"""
{"error":{"code":-32100,"message":"Failed to execute method."},"id":2,"jsonrpc":"2.0"}
"""
which makes the entire context menu fail and show only an error.
Fixes: #34