Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support AddSubtitle json-rpc API #43

Closed
wants to merge 1 commit into from

Conversation

pespin
Copy link
Contributor

@pespin pespin commented Nov 8, 2020

This new button allows passing a URL to Kodi to set up subtitles from
it.

See xbmc/xbmc#18445

TODO:

  • Add a new svg file for it (where did you get them from?)
  • Proper french transltion strings (would be great if you could provide them when reviewing)

This new button allows passing a URL to Kodi to set up subtitles from
it.

See xbmc/xbmc#18445

TODO:
- Add a new svg file for it
- Proper french transltion strings
@regseb
Copy link
Owner

regseb commented Dec 23, 2020

Thank you for the interesting proposal. But do not add this sending at the same level as cast a video / music. It's ambiguous to have three options for videos / music and one for subtitles. You should add a button in the popup that opens a dialog box (as for Send text).

For icons, I get it from Photon's collection. If it doesn't exist, I create it with these guidelines. Here is an icon for the subtitle: subtitle.zip

In keyboard controls of Kodi, the keyboard shortcut S is associated with the shutdown menu. You should use the letter T.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants