Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactoring Hash.lean #21

Merged
merged 2 commits into from
Nov 29, 2023
Merged

chore: refactoring Hash.lean #21

merged 2 commits into from
Nov 29, 2023

Conversation

Eagle941
Copy link
Contributor

@Eagle941 Eagle941 commented Nov 29, 2023 •
edited
Loading

Summary

Renamed perfect_hash to CollisionResistant
Renamed simp_hash to CollisionResistant_def

Details

Checklist

  • Code is formatted akin to the other code in the repo.
  • Documentation has been updated if necessary.

@Eagle941 Eagle941 requested a review from a team as a code owner November 29, 2023 11:56
kustosz
kustosz approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one more naming remark, otherwise this can be merged

ProvenZk/Hash.lean Outdated Show resolved Hide resolved
@Eagle941 Eagle941 changed the title chore: Renamed perfect_hash to CollisionResistant chore: refactoring Hash.lean Nov 29, 2023
@Eagle941 Eagle941 merged commit 1f19c61 into main Nov 29, 2023
1 check passed
@Eagle941 Eagle941 deleted the refactor_hash branch November 29, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kustosz kustosz kustosz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eagle941 @kustosz