Defer interactions correctly #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keeping this PR open until everything works as it should. |
Closed
reinacchi
commented
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had opened 3 pull requests regarding this and yet I had to revert them all. However, this should really fix the main issue of interactions aren't responding.
From what I've seen from the logs, it seems that this issue occurs depending on the circumstances. Interaction defer won't work when there's no network interruption between the client and the API however, interaction defer is needed when API fetch takes more than 3 seconds to finish.
In the end, I implemented a timeout of up to 4 seconds to defer and let it do the rest. Although this is recommended to do on all Discord bots yet, I never noticed.