adds dired to defcustom #110
Conversation
|
I think we should call this variable something else. I don't know what name would be good, but perhaps something like "file manager"? |
prodigy.el
Outdated
| could use any other `dired' like function. To use e.g. `ranger' | ||
| set it to `deer'" | ||
| :group 'prodigy | ||
| :type 'symbol) |
There was a problem hiding this comment.
This should be a function type instead of symbol, that way Emacs can validate it's a function and even give better completion.
For extra bonus points use radio and pre-fill the most common options (so dired and deer for example) and add a row for "custom function" See https://www.gnu.org/software/emacs/manual/html_node/elisp/Composite-Types.html#Composite-Types
There was a problem hiding this comment.
For an example you can look here: https://github.com/Fuco1/smartparens/blob/master/smartparens.el#L1369
There was a problem hiding this comment.
I didn't know about this, thanks
prodigy.el
Outdated
| @@ -1279,7 +1287,7 @@ SIGNINT signal." | |||
| "Jump to dired mode for service at point." | |||
| (interactive) | |||
| (-when-let (service (prodigy-service-at-pos)) | |||
| (dired (prodigy-service-cwd service)))) | |||
| (funcall prodigy-file-manager (prodigy-service-cwd service)))) | |||
There was a problem hiding this comment.
You should also update the name of this (prodigy-jump-dired ) method and update the docs for it. There is also a binding to this function.
There was a problem hiding this comment.
Makes sense, I renamed that function and updated the doc, would it be ok what I wrote?
- adds radio vaoues dired & deer - renames prodigy-jump-dired and updates docstring
This function was renamed in rejeep/prodigy.el#110
|
Kind reminder, if is there something else I could in this PR please let me know, I'll be glad to do it. Thanks in advance for your time |
There was a problem hiding this comment.
Sorry about that @FrancescElies, looks good now, will merge!
Nothing to be sorry about, thanks for your help! |
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
This function was renamed in rejeep/prodigy.el#110
I would like to use ranger's
deerinstead ofdiredwhenprodigy-jump-diredCould we add a configuration parameter with
defcustom?