Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'make' is flaky with "address already in use" errors #32

Closed
tormoder opened this issue Sep 13, 2017 · 2 comments
Closed

'make' is flaky with "address already in use" errors #32

tormoder opened this issue Sep 13, 2017 · 2 comments
Assignees
@tormoder

Comments

@tormoder
Copy link
Contributor

No description provided.

@tormoder tormoder self-assigned this Sep 13, 2017
@meling
Copy link
Member

meling commented Sep 13, 2017

I'm not able to reproduce this. Can you provide more details?

@tormoder tormoder changed the title Tests are again flaky with "address already in use" errors 'make test' flaky with "address already in use" errors Sep 14, 2017
@tormoder tormoder changed the title 'make test' flaky with "address already in use" errors 'make test' is flaky with "address already in use" errors Sep 14, 2017
@tormoder tormoder changed the title 'make test' is flaky with "address already in use" errors 'make' is flaky with "address already in use" errors Sep 14, 2017
tormoder added a commit that referenced this issue Sep 14, 2017
@tormoder
dev: add flag to specify a specific port base for listeners in tests
0281ce1 
Updates #32.
tormoder added a commit that referenced this issue Sep 14, 2017
@tormoder
endtoend_test.go: invoke 'go test' with '-portbase' flag
621cd1c 
Updates #32.
@tormoder
Copy link
Contributor Author

I got errors like below when running make/make test locally:

--- FAIL: TestPerNodeArg (0.00s)
        config_qc_test.go:1373: failed to listen: listen tcp 127.0.0.1:22368: bind: address already in use

I think it is due to the fact that the testsuite in dev being run two times, and they now did so concurrently causing the errors. The testsuite is executed one time as a regular go test, and one time as part of the end-to-end test.

I have tried to fix this with the recent commits. Will reopen if I see this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tormoder tormoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tormoder @meling