ipmplement to_asciibib #28 #29

andrew2net · 2020-08-13T13:03:43Z

No description provided.

hound · 2020-08-13T13:03:58Z

lib/relaton_bib/typed_title_string.rb

+    # @param prefix [String]
+    # @param count [Integer] number of titles
+    # @return [String]
+    def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize


Unnecessary disabling of Metrics/AbcSize.

hound · 2020-08-13T13:03:58Z

lib/relaton_bib/localized_string.rb

+    # @param prefix [String]
+    # @param count [Integer] number of elements
+    # @return [String]
+    def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [107/80]

hound · 2020-08-13T13:03:59Z

lib/relaton_bib/localized_string.rb

@@ -61,7 +62,7 @@ def to_xml(builder)
    end

    # @return [Hash]
-    def to_hash
+    def to_hash # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-13T13:03:59Z

lib/relaton_bib/localized_string.rb

@@ -48,7 +49,7 @@ def empty?
    end

    # @param builder [Nokogiri::XML::Builder]
-    def to_xml(builder)
+    def to_xml(builder) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [87/80]

hound · 2020-08-13T13:03:59Z

lib/relaton_bib/localized_string.rb

-      unless content.is_a?(String) || content.is_a?(Array) &&
-          (inv = content.reject { |c| c.is_a?(LocalizedString) || c.is_a?(Hash) }).
-              none? && content.any?
+    def initialize(content, language = nil, script = nil) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity


Line is too long. [172/80]

hound · 2020-08-13T13:04:00Z

lib/relaton_bib/hash_converter.rb

@@ -238,7 +239,7 @@ def person_identifiers_hash_to_bib(person)
        end
      end

-      def affiliation_hash_to_bib(person)
+      def affiliation_hash_to_bib(person) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength


Line is too long. [97/80]

hound · 2020-08-13T13:04:00Z

lib/relaton_bib/hash_converter.rb

        )
      end

-      def fullname_hash_to_bib(person)
+      def fullname_hash_to_bib(person) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [102/80]

hound · 2020-08-13T13:04:00Z

lib/relaton_bib/hash_converter.rb

@@ -177,7 +178,7 @@ def stage(stg)
        DocumentStatus::Stage.new(**args)
      end

-      def contributors_hash_to_bib(ret)
+      def contributors_hash_to_bib(ret) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [125/80]

hound · 2020-08-13T13:04:01Z

lib/relaton_bib/series.rb

+    # @param prefix [String]
+    # @param count [Integer]
+    # @return [String]
+    def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength,Metrics/PerceivedComplexity


Line is too long. [157/80]

hound · 2020-08-13T13:04:01Z

lib/relaton_bib/series.rb

@@ -95,7 +97,7 @@ def to_xml(builder)
    # rubocop:enable Metrics/PerceivedComplexity

    # @return [Hash]
-    def to_hash
+    def to_hash # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity


Line is too long. [130/80]

ronaldtse · 2020-08-13T17:43:39Z

Thanks @andrew2net , feel free to merge when ready.

hound · 2020-08-14T10:48:58Z

lib/relaton_bib/bibliographic_item.rb

@@ -504,7 +560,7 @@ def bibtex_contributor(item)
    # rubocop:enable Metrics/AbcSize, Metrics/MethodLength

    # @param [BibTeX::Entry]
-    def bibtex_note(item)
+    def bibtex_note(item) # rubocop:disable Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-14T10:48:58Z

lib/relaton_bib/bibliographic_item.rb

@@ -487,7 +543,7 @@ def bibtex_author(item)
    end

    # @param [BibTeX::Entry]
-    def bibtex_contributor(item)
+    def bibtex_contributor(item) # rubocop:disable Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-14T10:48:58Z

lib/relaton_bib/bibliographic_item.rb

@@ -470,7 +526,7 @@ def bibtex_type
    # rubocop:disable Metrics/AbcSize, Metrics/MethodLength

    # @param [BibTeX::Entry]
-    def bibtex_author(item)
+    def bibtex_author(item) # rubocop:disable Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-14T10:48:58Z

lib/relaton_bib/bibliographic_item.rb

      @revdate ||= if version&.revision_date
                     version.revision_date
                   else
                     date.detect { |d| d.type == "published" }&.on&.to_s
                   end
    end

+    # @param prefix [String]
+    # @return [String]
+    def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity


Line is too long. [147/80]

hound · 2020-08-14T10:48:58Z

lib/relaton_bib/bibliographic_item.rb

@@ -440,14 +449,61 @@ def to_most_recent_reference

    # If revision_date exists then returns it else returns published date or nil
    # @return [String, NilClass]
-    def revdate
+    def revdate # rubocop:disable Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-14T10:48:59Z

lib/relaton_bib/organization.rb

+    # @param prefix [String]
+    # @param count [Integer]
+    # @return [String]
+    def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [107/80]

hound · 2020-08-14T10:49:00Z

lib/relaton_bib/copyright_association.rb

+    # @param prefix [String]
+    # @param count [Iteger] number of copyright elements
+    # @return [String]
+    def to_asciibib(prefix = "", count = 1) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [107/80]

hound · 2020-08-14T10:49:00Z

lib/relaton_bib/contributor.rb

+
+    # @param prefix [String]
+    # @return [String]
+    def to_asciibib(prefix = "") # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [96/80]

hound · 2020-08-14T10:49:00Z

lib/relaton_bib.rb

  end

  private

  # @param array [Array]
  # @return [Array<String>, String]
-  def single_element_array(array)
+  def single_element_array(array) # rubocop:disable Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-14T10:49:00Z

lib/relaton_bib.rb

    # @param date [String, Integer, Date]
    # @return [Date, NilClass]
-    def parse_date(date)
+    def parse_date(date) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength


Line is too long. [93/80]

hound · 2020-08-19T14:28:44Z

lib/relaton_bib/xml_parser.rb

      # @param ext [Nokogiri::XML::Element]
      # @return [RelatonBib::StructuredIdentifierCollection]
-      def fetch_structuredidentifier(ext)
+      def fetch_structuredidentifier(ext) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity


Line is too long. [127/80]
Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-19T14:28:45Z

lib/relaton_bib/xml_parser.rb

@@ -219,7 +229,7 @@ def get_org(org)
                         identifier: identifier)
      end

-      def get_person(person)
+      def get_person(person) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity


Line is too long. [114/80]
Unnecessary disabling of Metrics/CyclomaticComplexity.

hound · 2020-08-19T14:28:45Z

lib/relaton_bib/xml_parser.rb

      end

-      def fetch_dates(item)
+      def fetch_dates(item) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [91/80]

hound · 2020-08-19T14:28:45Z

lib/relaton_bib/xml_parser.rb

-      # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-
-      def fetch_series(item)
+      def fetch_series(item) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/AbcSize, Metrics/MethodLength


Unnecessary disabling of Metrics/CyclomaticComplexity.
Line is too long. [114/80]

hound · 2020-08-19T14:28:45Z

lib/relaton_bib/xml_parser.rb

@@ -19,7 +20,7 @@ def from_xml(xml)
      # rubocop:disable Metrics/MethodLength, Metrics/AbcSize

      # @return [Hash]
-      def item_data(bibitem)
+      def item_data(bibitem) # rubocop:disable Metrics/CyclomaticComplexity


Unnecessary disabling of Metrics/CyclomaticComplexity.

ipmplement to_asciibib #28

cbf0187

hound bot reviewed Aug 13, 2020

View reviewed changes

andrew2net assigned ronaldtse and unassigned ronaldtse Aug 13, 2020

andrew2net requested a review from ronaldtse August 13, 2020 14:46

ronaldtse approved these changes Aug 13, 2020

View reviewed changes

fix test

8bf6150

hound bot reviewed Aug 14, 2020

View reviewed changes

fix rubocop offences

9886fbe

hound bot reviewed Aug 19, 2020

View reviewed changes

andrew2net added 7 commits August 19, 2020 23:01

update README

a643a32

fix ubuntu test

d00c179

fix ubuntu test

e50a544

fix ubuntu test

d13dadf

fix ubuntu test

9723a4b

fix ubuntu test

5c5445e

fix ubuntu test

3fb3b85

andrew2net merged commit 6222971 into master Aug 19, 2020

andrew2net deleted the feature/to_asciibib branch August 19, 2020 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ipmplement to_asciibib #28 #29

ipmplement to_asciibib #28 #29

andrew2net commented Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

hound bot Aug 13, 2020

ronaldtse commented Aug 13, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 14, 2020

hound bot Aug 19, 2020

hound bot Aug 19, 2020

hound bot Aug 19, 2020

hound bot Aug 19, 2020

hound bot Aug 19, 2020

ipmplement to_asciibib #28 #29

ipmplement to_asciibib #28 #29

Conversation

andrew2net commented Aug 13, 2020

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

hound bot Aug 13, 2020

Choose a reason for hiding this comment

ronaldtse commented Aug 13, 2020

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 14, 2020

Choose a reason for hiding this comment

hound bot Aug 19, 2020

Choose a reason for hiding this comment

hound bot Aug 19, 2020

Choose a reason for hiding this comment

hound bot Aug 19, 2020

Choose a reason for hiding this comment

hound bot Aug 19, 2020

Choose a reason for hiding this comment

hound bot Aug 19, 2020

Choose a reason for hiding this comment