-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(URGENT) Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969)
instead of CIPM Resolution 1 (1969)
)
#19
Comments
CIPM Recommendation 1 (1969)
instead of CIPM Resolution 1 (1969)
)
To paraphrase the bug here: CIPM outcomes can be a "Recommendation" or a "Resolution". The link provided here: Is clear a Therefore, in accordance with the official pattern provided by BIPM here:
It should be retrieved using the syntax:
And also allowed to be retrieved using this syntax:
|
CIPM Recommendation 1 (1969)
instead of CIPM Resolution 1 (1969)
)CIPM Recommendation 1 (1969)
instead of CIPM Resolution 1 (1969)
)
@ronaldtse some CIPM outcomes have type "decision". Does it mean CIPM outcome should be "Recommendation" if it has |
@ronaldtse @manuel489 we create document from metadata and from resolutions.
So the question is: what type should be documents created from metadata? |
Are we mixing things here? There are 4 types of BIPM data (see https://github.com/metanorma/bipm-data-importer):
There are only four outcome types:
These outcome types are all specified in the data. There should not be an instance without type.
I'd like to clarify the terminology here. Relaton does not create "documents" as data, it creates bibliographic items that allow reference. These are the things that can be referred to in Relaton-BIPM:
In order for these things to be referenced, we need to create them in relaton-data-bipm. This also means that every outcome should have its own file in relaton-data-bipm. |
Saying metadata I meant section
I see the new attribute
In the bipm-data-outcomes I found only |
Yes, as mentioned in those tickets above, the
Yes. Just use specified type. |
As mentioned earlier, we need these types:
CIPM outcomeshttps://github.com/metanorma/bipm-data-outcomes/tree/main/cipm provides these objects:
CGPM outcomeshttps://github.com/metanorma/bipm-data-outcomes/tree/main/cgpm
CCTF outcomeshttps://github.com/metanorma/bipm-data-outcomes/tree/main/cctf
|
CIPM Recommendation 1 (1969)
instead of CIPM Resolution 1 (1969)
)CIPM Recommendation 1 (1969)
instead of CIPM Resolution 1 (1969)
)
Confirm fixed. Thanks @andrew2net ! |
References like (PV, 37, 30) should fetch with
CIPM Recommendation 01 (1969)
, notCIPM Resolution 01 (1969)
.As they are recommendations. Like indicated in https://github.com/metanorma/bipm-data-outcomes/blob/576929b1ab359bfe4397b40865e1cb65cf575a76/cipm/meetings-en/meeting-58.yml#L9-L12.
The text was updated successfully, but these errors were encountered: