Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(URGENT) Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969) instead of CIPM Resolution 1 (1969)) #19

Closed
manuelfuenmayor opened this issue May 30, 2022 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@manuelfuenmayor
Copy link

References like (PV, 37, 30) should fetch with CIPM Recommendation 01 (1969), not CIPM Resolution 01 (1969).
As they are recommendations. Like indicated in https://github.com/metanorma/bipm-data-outcomes/blob/576929b1ab359bfe4397b40865e1cb65cf575a76/cipm/meetings-en/meeting-58.yml#L9-L12.

@manuelfuenmayor manuelfuenmayor added the bug Something isn't working label May 30, 2022
@ronaldtse ronaldtse changed the title Fix identifier for "Recommendation" CIPM references Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969) instead of CIPM Resolution 1 (1969)) May 30, 2022
@ronaldtse
Copy link
Contributor

ronaldtse commented May 30, 2022

To paraphrase the bug here:

CIPM outcomes can be a "Recommendation" or a "Resolution".

The link provided here:
https://github.com/metanorma/bipm-data-outcomes/blob/576929b1ab359bfe4397b40865e1cb65cf575a76/cipm/meetings-en/meeting-58.yml#L9-L12

Is clear a type: recommendation.

Therefore, in accordance with the official pattern provided by BIPM here:
metanorma/metanorma-bipm#164

[BODY] [Type] {number} (YEAR)

It should be retrieved using the syntax:

CIPM Recommendation 1 (1969)

And also allowed to be retrieved using this syntax:

CIPM Recommendation 1969-01

@ronaldtse ronaldtse changed the title Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969) instead of CIPM Resolution 1 (1969)) (URGNET) Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969) instead of CIPM Resolution 1 (1969)) May 30, 2022
@andrew2net
Copy link
Contributor

CIPM outcomes can be a "Recommendation" or a "Resolution".

@ronaldtse some CIPM outcomes have type "decision". Does it mean CIPM outcome should be "Recommendation" if it has type: recommendation and "Resolution" if it has any other type?

@andrew2net
Copy link
Contributor

@ronaldtse @manuel489 we create document from metadata and from resolutions.
Metadata doesn't have type attribute. I supposed that it possible to use for documents created from metadata same type as resolutions have but 2 documents have different resolution types:

So the question is: what type should be documents created from metadata?

@ronaldtse
Copy link
Contributor

Metadata doesn't have type attribute

Are we mixing things here?

There are 4 types of BIPM data (see https://github.com/metanorma/bipm-data-importer):

  • CGPM outcomes
  • CIPM outcomes
  • CIPM decisions
  • CCTF recommendations

Does it mean CIPM outcome should be "Recommendation" if it has type: recommendation and "Resolution" if it has any other type?

There are only four outcome types:

These outcome types are all specified in the data. There should not be an instance without type.

So the question is: what type should be documents created from metadata?

I'd like to clarify the terminology here. Relaton does not create "documents" as data, it creates bibliographic items that allow reference.

These are the things that can be referred to in Relaton-BIPM:

  • meetings (CIPM meetings, CGPM meetings)
  • outcomes (recommendation, resolution, decision, declaration)
  • documents (SI Brochure and other documents in bipm-si-brochure)

In order for these things to be referenced, we need to create them in relaton-data-bipm.

This also means that every outcome should have its own file in relaton-data-bipm.

@andrew2net
Copy link
Contributor

Metadata doesn't have type attribute

Are we mixing things here?

There are 4 types of BIPM data (see https://github.com/metanorma/bipm-data-importer):

  • CGPM outcomes
  • CIPM outcomes
  • CIPM decisions
  • CCTF recommendations

Saying metadata I meant section metadata in the bipm-data-outcomes. For example we create the document from the metadata section. Which type the document should be? Meeting?

There are only four outcome types:

These outcome types are all specified in the data. There should not be an instance without type.

I see the new attribute type in the resolutions collection. I was confused by your phrase:

CIPM outcomes can be a "Recommendation" or a "Resolution".

In the bipm-data-outcomes I found only recommendation and decision for CIPM body.
So we just use specified type, correct?

@ronaldtse
Copy link
Contributor

I see the new attribute type in the resolutions collection.

Yes, as mentioned in those tickets above, the type is somewhat new, but not that new (April 13).

In the bipm-data-outcomes I found only recommendation and decision for CIPM body.
So we just use specified type, correct

Yes. Just use specified type.

@ronaldtse
Copy link
Contributor

Saying metadata I meant section metadata in the bipm-data-outcomes. For example we create the document from the metadata section. Which type the document should be? Meeting?

As mentioned earlier, we need these types:

  • meetings (CIPM meetings, CGPM meetings)
  • outcomes (recommendation, resolution, decision, declaration)
  • documents (SI Brochure and other documents in bipm-si-brochure)

CIPM outcomes

https://github.com/metanorma/bipm-data-outcomes/tree/main/cipm provides these objects:

  • meetings
    • resolutions (decision, recommendation, etc.)

CGPM outcomes

https://github.com/metanorma/bipm-data-outcomes/tree/main/cgpm

  • meetings
    • resolutions (resolution, recommendation, etc.)

CCTF outcomes

https://github.com/metanorma/bipm-data-outcomes/tree/main/cctf

  • meetings
    • resolutions (recommendation, etc.) (there's only one here)

@ronaldtse ronaldtse changed the title (URGNET) Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969) instead of CIPM Resolution 1 (1969)) (URGENT) Fix retrieval syntax for "Recommendation" CIPM references (allow CIPM Recommendation 1 (1969) instead of CIPM Resolution 1 (1969)) May 30, 2022
andrew2net added a commit to relaton/relaton-data-bipm that referenced this issue May 31, 2022
andrew2net added a commit to relaton/relaton-data-bipm that referenced this issue May 31, 2022
andrew2net added a commit that referenced this issue May 31, 2022
andrew2net added a commit to relaton/relaton-data-bipm that referenced this issue May 31, 2022
andrew2net added a commit to relaton/relaton-data-bipm that referenced this issue May 31, 2022
andrew2net added a commit that referenced this issue May 31, 2022
@ronaldtse
Copy link
Contributor

Confirm fixed. Thanks @andrew2net !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants