setup aws environment variables before signing #211
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 3029 3033 +4
=========================================
+ Hits 3029 3033 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
https://github.com/release-engineering/pubtools-quay/blob/master/pubtools/_quay/tag_docker.py#L655 Signing is not split here.
| @@ -549,6 +553,7 @@ def copy_tag_sign_images(self, push_item: Any, tag: str, executor: Executor) -> | |||
| continue | |||
| outdated_manifests.append((mad.digest, tag, repo)) | |||
|
|
|||
| set_aws_kms_environment_variables(self.target_settings, "cosign_signer") | |||
There was a problem hiding this comment.
Is the key needed for pre-push signing?
There was a problem hiding this comment.
It's not, but I thought it would be probably better to just keep setup of aws variables before every signing as it devs then doesn't need to remember and determine whether it's needed or not.
- Added aws setup before signing of index images
I'll fix it in #212 |
No description provided.