Sign entries for cosign also for sign new manifests and tag docker #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 26 26
Lines 3106 3226 +120
==========================================
+ Hits 3106 3226 +120 ☔ View full report in Codecov by Sentry. |
emilyzheng
reviewed
Mar 6, 2024
emilyzheng
reviewed
Mar 6, 2024
- Added missing namespace in copy_tag_sign_images
emilyzheng
reviewed
Mar 6, 2024
pubtools/_quay/tag_docker.py
Outdated
| @@ -666,7 +697,7 @@ def merge_manifest_lists_sign_images( | |||
| if outdated_manifests: | |||
| signer.remove_signatures(outdated_manifests, _exclude=current_signatures) | |||
| signer.sign_containers( | |||
| to_sign_entries, | |||
| to_sign_entries if signercls.pre_push else to_sign_entries_internal, | |||
There was a problem hiding this comment.
It should always be to_sign_entries as it's already in if pre_push is true. And line #733 needs to be to_sign_entries_internal.
emilyzheng
approved these changes
Mar 11, 2024
querti
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.