Use cmp_version package for version comparison #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously used rpm-vercmp was unreliable for some variants of version, so this commit moves to cmp_version python package which is more reliable.
alexandrevicenzi
previously approved these changes
Apr 26, 2019
midnightercz
requested changes
Apr 26, 2019
alexandrevicenzi
approved these changes
Apr 29, 2019
danrodrig
approved these changes
Apr 29, 2019
midnightercz
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously used rpm-vercmp was unreliable for
some variants of version, so this commit
moves to cmp_version python package which
is more reliable.
Fix #66 .