Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed VERSION as 0.10 #366

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fixed VERSION as 0.10 #366

merged 1 commit into from
Nov 26, 2023

Conversation

sasezaki
Copy link
Contributor

It seems missing changed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6992390278

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.043%
Totals Coverage Status
Change from base Build 6990981835: 0.0%
Covered Lines: 4868
Relevant Lines: 5862
💛 - Coveralls

@sasezaki
Copy link
Contributor Author

IMO, I recommend use https://getcomposer.org/doc/07-runtime.md#installed-versions or https://github.com/composer/package-versions-deprecated

@sj-i sj-i merged commit 278c3f6 into reliforp:0.10.x Nov 26, 2023
3 checks passed
@sj-i
Copy link
Member

sj-i commented Nov 26, 2023

Thanks!
And also thanks to the recommendation! I'll try it.

sj-i added a commit that referenced this pull request Nov 27, 2023
@sj-i
Use Composer\InstalledVersions to retrieve the installed version
edb2a79 
Following the recommendation from @sasezaki at #366
@sj-i sj-i mentioned this pull request Nov 27, 2023
Merged
@sj-i sj-i added this to the 0.10.1 milestone Nov 27, 2023
@sj-i sj-i added the bug Something isn't working label Nov 27, 2023
@sj-i sj-i mentioned this pull request Nov 27, 2023
Merged
@sasezaki sasezaki deleted the patch-1 branch November 28, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sasezaki @coveralls @sj-i