Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$_SERVER[ 'REQUEST_SCHEME' ] is not reliable #174

Closed
kevsgithub opened this issue Jul 9, 2018 · 1 comment
Closed

$_SERVER[ 'REQUEST_SCHEME' ] is not reliable #174

kevsgithub opened this issue Jul 9, 2018 · 1 comment
Labels
bug enhancement

Comments

@kevsgithub
Copy link

kevsgithub commented Jul 9, 2018 •
edited
Loading

Many webservers (Apache, Lighttpd, IIS) do not pass the REQUEST_SCHEME to php as they do not know if they are behind a ssl proxy etc.
ota updates fail as the url passed to client is "://{ip}:80/data/firmwares/sonoff-minimal.bin"

please add a check to REQUEST_SCHEME and if missing drop back to SERVER_PORT if 80/433 or allow user configuration.

FastCGI-stderr: PHP Notice: Undefined index: REQUEST_SCHEME in /var/www/pages/device_update. php on line 12
@reloxx13
Copy link
Collaborator

reloxx13 commented Jul 9, 2018

yup, ill do that, thank you ! 👍

reloxx13 added a commit that referenced this issue Jul 12, 2018
@reloxx13
$_SERVER REQUEST_SCHEME is not reliable #174
6f0d413
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Oct 14, 2020
@reloxx13
$_SERVER REQUEST_SCHEME is not reliable TasmoAdmin#174
e6c45d9
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Apr 11, 2022
@reloxx13
$_SERVER REQUEST_SCHEME is not reliable TasmoAdmin#174
ea6c0ec 
Former-commit-id: 6f0d413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevsgithub @reloxx13