Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.7.0 beta1 - selecting Command/ALL with active search/filter selects ALL (also from hidden rows) #400

Closed
alexhk opened this issue Sep 25, 2020 · 2 comments
Closed

1.7.0 beta1 - selecting Command/ALL with active search/filter selects ALL (also from hidden rows) #400

alexhk opened this issue Sep 25, 2020 · 2 comments
Labels
bug

Comments

@alexhk
Copy link
Contributor

alexhk commented Sep 25, 2020

I installed the new 1.7.1 beta1 at work this morning and just realized that when a filter/search is active and one selects Command/ALL and sends a command, it will be sent to ALL devices, not only the ones shown.
This situation is probably too risky to be ignored for a release.

I was lucky, I just wanted to see ruletimers (Tasmota command 'ruletimer') for a few of my devices, but imagine if I'd have made a setting change via command and would have only later realized all my devices got changed :/

In a best possible scenario the ALL checkbox would only select the checkboxes of the visible devices.
@alexhk alexhk changed the title 1.7.0 beta1 - selecting Command/ALL with active search/filter selects ALL 1.7.0 beta1 - selecting Command/ALL with active search/filter selects ALL (also from hidden rows) Sep 25, 2020
@reloxx13
Copy link
Collaborator

yeah i noticed it while updating, its the same on the update page >.<

reloxx13 added a commit that referenced this issue Sep 25, 2020
@reloxx13
- FIX: Select all and filter were conflicting, fixes [#400](#400)
056e5c6 
- FIX: Select all style position
@reloxx13
Copy link
Collaborator

fixed in upcoming v1.7.0-beta2 and will be released tomorrow/this night if everything is fine

inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Oct 14, 2020
@reloxx13
- FIX: Select all and filter were conflicting, fixes [TasmoAdmin#400](T…
bc1081d 
…asmoAdmin#400)

- FIX: Select all style position
inverse pushed a commit to inverse/TasmoAdmin that referenced this issue Apr 11, 2022
@reloxx13
- FIX: Select all and filter were conflicting, fixes [TasmoAdmin#400](T…
b8188fa 
…asmoAdmin#400)

- FIX: Select all style position


Former-commit-id: 056e5c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexhk @reloxx13