Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregistered Firmware source location keyboards are not editable #771

Open
yfuku opened this issue Oct 30, 2023 · 4 comments
Open

Unregistered Firmware source location keyboards are not editable #771

yfuku opened this issue Oct 30, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@yfuku
Copy link

yfuku commented Oct 30, 2023

I attempted to register my keyboard definition from an individual to an organization. While most modifications were successful, I encounter an error when trying to modify a keyboard definition with an 'Unknown' Firmware source location.

Steps to reproduce:

Select the keyboard from the REGISTER/MANAGE KEYBOARDS page.
Click on the 'BACK TO DRAFT' link under the DEFINITION tab.
An error message 'Updating the Keyboard Definition failed' is displayed.
The page remains stuck on 'Processing...'
This issue pertains to two keyboards: bat43 and Claw44 rev1.
It is likely that these keyboards were registered during an earlier period.
sc 2

@yoichiro
Copy link
Collaborator

yoichiro commented Nov 4, 2023

@yfuku Thank you for submitting this issue and talking in person today. I intend to confirm this issue and will fix this as soon as possible. Probably I will try to fix this issue next week.

@yoichiro yoichiro added the bug Something isn't working label Nov 4, 2023
yoichiro added a commit that referenced this issue Nov 14, 2023
yoichiro added a commit that referenced this issue Nov 14, 2023
@yoichiro
Copy link
Collaborator

@yfuku This issue should be fixed at #775. Could you confirm it? You can reopen this issue if this issue is not solved.

@yfuku
Copy link
Author

yfuku commented Nov 17, 2023

@yoichiro
Thank you for addressing this issue.
An error has occurred again. It seems that there is no data in the database for qmkRepositoryFirstPullRequestUrl.

Upon comparing with keyboards that are registered correctly, it was found that qmkRepositoryFirstPullRequestUrl and contactInformation are missing. However, since contactInformation is defined as 'string | undefined', I believe the latter should not be a problem.

I'm sorry, but I can't make a pull request because I am unable to replicate the admin panel.

@yfuku
Copy link
Author

yfuku commented Nov 17, 2023

It seems that only collaborators or the person who closed the issue can reopen it. Sorry, I can't change the status

@yoichiro yoichiro reopened this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants