test(helpers): refactor and move runTests to its own file

Author: remarkablemark

test/helpers/run-tests.js

@@ -0,0 +1,31 @@
+/**
+ * Runs tests.
+ *
+ * @param {Object}   testCases      - The test cases.
+ * @param {Function} expectedParser - The expected parser.
+ * @param {Function} actualParser   - The actual parser.
+ * @param {Function} [assert]       - The assertion module.
+ */
+function runTests(testCases, expectedParser, actualParser, assert) {
+  if (typeof assert !== 'function') {
+    assert = require('assert');
+  }
+
+  if (typeof expectedParser !== 'function') {
+    throw new TypeError('Missing or invalid expected parser');
+  }
+
+  if (typeof actualParser !== 'function') {
+    throw new TypeError('Missing or invalid actual parser');
+  }
+
+  Object.keys(testCases).forEach(function(type) {
+    var testCase = testCases[type];
+
+    it(type, function() {
+      assert.deepEqual(expectedParser(testCase), actualParser(testCase));
+    });
+  });
+}
+
+module.exports = runTests;

test/html-to-dom-server.js

@@ -1,24 +1,10 @@
 const { assert } = require('chai');
 const htmlparser = require('htmlparser2');
 const cases = require('./cases');
+const runTests = require('./helpers/run-tests');
 const throwsError = require('./helpers/throws-error');
 const { CASE_SENSITIVE_TAG_NAMES } = require('../lib/constants');
 
-/**
- * Runs test cases.
- *
- * @param {Function} parser - The parser.
- * @param {Object}   cases  - The test cases.
- */
-function runTests(parser, cases) {
-  Object.keys(cases).forEach(type => {
-    it(type, () => {
-      const data = cases[type];
-      assert.deepEqual(parser(data), htmlparser.parseDOM(data));
-    });
-  });
-}
-
 /**
  * Tests case-sensitive tags (SVG) to make sure their case is preserved.
  *
@@ -39,8 +25,8 @@ describe('server parser', () => {
 
   // tests
   throwsError(parser);
-  runTests(parser, cases.html);
-  runTests(parser, cases.svg);
+  runTests(cases.html, parser, htmlparser.parseDOM);
+  runTests(cases.svg, parser, htmlparser.parseDOM);
 });
 
 describe('client parser in jsdom', () => {
@@ -51,8 +37,8 @@ describe('client parser in jsdom', () => {
 
   // tests
   throwsError(parser);
-  runTests(parser, cases.html);
-  runTests(parser, cases.svg);
+  runTests(cases.html, parser, htmlparser.parseDOM);
+  runTests(cases.svg, parser, htmlparser.parseDOM);
   testCaseSensitiveTags(parser);
 
   // after