Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: treat blob: urls as safe url #796

Closed
wants to merge 1 commit into from
Closed

Conversation

erfanium
Copy link

@erfanium erfanium commented Nov 12, 2023

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

I use react-markdown to preview an text input when images have not been uploaded to server. so it would be nice to be able to render blob images

Signed-off-by: Erfan Safari  <erfanshield@outlook.com>
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Nov 12, 2023

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2245c64) 100.00% compared to head (b643a31) 100.00%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #796   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines         1354      1354           
  Branches       113       113           
=========================================
  Hits          1354      1354           
Files Coverage Δ
lib/index.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 12, 2023
@wooorm
Copy link
Member

wooorm commented Nov 13, 2023

You are proposing to change the defaults for everyone. Blobs are not always safe. You can already pass different things if you want that. Pass urlTransform in options

@wooorm wooorm closed this Nov 13, 2023
@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label Nov 13, 2023

This comment has been minimized.

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

3 participants