Bug: Tables without final newline

[quantizor]

remark.parse("|foo|bar|\n|-|-|\n|1|2|") results in mdast with the following shape:

{
    type: 'root',
    children: [
        {
            type: 'table',
            align: [
                null,
                null
            ],
            children: [
                {
                    type: 'tableHeader',
                    children: [
                        Object
                    ]
                }
            ]
        },
        {
            type: 'paragraph',
            children: [
                {
                    type: 'text',
                    value: '|1|2|',
                    position: [
                        Object
                    ]
                }
            ]
        }
    ]
}

(I took out the position objects to make the above more concise.)

For some reason the row is being pulled out as a paragraph now. I see there are some new table options added to the parse configuration object and toyed with them, but neither seems to fix the issue.

Parsing the above string definitely worked in the 2.x tree.

[wooorm]

I think 3.1.3 closed this. I got these results with the aforementioned example:

{
  "type": "root",
  "children": [
    {
      "type": "table",
      "align": [
        null,
        null
      ],
      "children": [
        {
          "type": "tableHeader",
          "children": [
            {
              "type": "tableCell",
              "children": [
                {
                  "type": "text",
                  "value": "foo"
                }
              ]
            },
            {
              "type": "tableCell",
              "children": [
                {
                  "type": "text",
                  "value": "bar"
                }
              ]
            }
          ]
        },
        {
          "type": "tableRow",
          "children": [
            {
              "type": "tableCell",
              "children": [
                {
                  "type": "text",
                  "value": "1"
                }
              ]
            },
            {
              "type": "tableCell",
              "children": [
                {
                  "type": "text",
                  "value": "2"
                }
              ]
            }
          ]
        }
      ]
    }
  ]
}

[quantizor]

3.1.3 was installed when I tried it :/

On Jan 5, 2016, at 3:51 AM, Titus Wormer notifications@github.com wrote:

I think 3.1.3 closed this. I got these results with the aforementioned example:

{
"type": "root",
"children": [
{
"type": "table",
"align": [
null,
null
],
"children": [
{
"type": "tableHeader",
"children": [
{
"type": "tableCell",
"children": [
{
"type": "text",
"value": "foo"
}
]
},
{
"type": "tableCell",
"children": [
{
"type": "text",
"value": "bar"
}
]
}
]
},
{
"type": "tableRow",
"children": [
{
"type": "tableCell",
"children": [
{
"type": "text",
"value": "1"
}
]
},
{
"type": "tableCell",
"children": [
{
"type": "text",
"value": "2"
}
]
}
]
}
]
}
]
}
—
Reply to this email directly or view it on GitHub.

[wooorm]

Then I’m guessing the problem is the missing EOF EOL, I’ll check.

[quantizor]

@wooorm You're right, it works if I add another newline to the end of the string. Is there a way to overcome the need for it?

[quantizor]

🎉 thanks!

[wooorm]

No problem, thanks for reporting! 😄