Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial, final newlines in fenced code #423

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Fix initial, final newlines in fenced code #423

merged 1 commit into from
Jul 15, 2019

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Jul 15, 2019

Closes GH-351.

@wooorm wooorm requested a review from a team July 15, 2019 09:18
@wooorm wooorm merged commit f89fd77 into master Jul 15, 2019
@wooorm wooorm deleted the fenced-code-newlines branch July 15, 2019 17:08
This was referenced Feb 27, 2021
Closed
Closed
btmills added a commit to eslint/markdown that referenced this pull request Feb 27, 2021
@btmills
Update: Upgrade remark-parse to v7 (fixes #77, fixes #78)
dc2d2ec 
`remark-parse@7.0.0` includes
remarkjs/remark#423, which fixes handling of
leading and trailing newlines in fenced code blocks.

Tagging this as `Update` so it'll be semver-minor. Are we comfortable
with a parser major version bump in a semver-minor release?
This was referenced Feb 27, 2021
Merged
Closed
btmills added a commit to eslint/markdown that referenced this pull request Apr 25, 2021
@btmills
Update: Upgrade remark-parse to v7 (fixes #77, fixes #78) (#175)
f1e153b 
`remark-parse@7.0.0` includes
remarkjs/remark#423, which fixes handling of
leading and trailing newlines in fenced code blocks.

Tagging this as `Update` so it'll be semver-minor. Are we comfortable
with a parser major version bump in a semver-minor release?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@fazouane-marouane fazouane-marouane fazouane-marouane approved these changes

Assignees
No one assigned
Labels
remark-parse remark-stringify 🐛 type/bug This is a problem
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CommonMark] Leading/trailing newlines are stripped in the value of fenced codeblock
3 participants
@wooorm @fazouane-marouane @ChristianMurphy