-
-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use markdown-extensions #1195
Use markdown-extensions #1195
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 885 874 -11
=========================================
- Hits 885 874 -11
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @remcohaszing!
This comment has been minimized.
This comment has been minimized.
My hunch is that when ESM started in Node, it couldn’t load JSON, even from ESM -> CJS -> JSON, but not sure anymore |
Thanks, also for getting the types in there! |
I remembered: ESM can, as you know, import CJS. But, at least at the start, when using ESM here, it could not load JSON in that CJS. |
Initial checklist
Description of changes
I don’t know why it was problematic earlier, but
markdown-extensions
has just been changes to ESM itself and now has type definitions.