Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown-extensions #1195

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Use markdown-extensions #1195

merged 1 commit into from
Aug 5, 2023

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

I don’t know why it was problematic earlier, but markdown-extensions has just been changes to ESM itself and now has type definitions.

@remcohaszing remcohaszing added the 🤞 phase/open Post is being triaged manually label Aug 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e72d91a) 100.00% compared to head (5f0c634) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1195   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          885       874   -11     
=========================================
- Hits           885       874   -11     
Files Changed Coverage Δ
packages/remark-cli/cli.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remcohaszing!

@wooorm wooorm merged commit 1c6e5ba into main Aug 5, 2023
10 checks passed
@wooorm wooorm deleted the markdown-extensions branch August 5, 2023 20:37
@github-actions

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Aug 5, 2023

My hunch is that when ESM started in Node, it couldn’t load JSON, even from ESM -> CJS -> JSON, but not sure anymore

@wooorm wooorm added the 💪 phase/solved Post is done label Aug 5, 2023
@wooorm
Copy link
Member

wooorm commented Aug 5, 2023

Thanks, also for getting the types in there!

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 5, 2023
@wooorm
Copy link
Member

wooorm commented Sep 18, 2023

I don’t know why it was problematic earlier,

I remembered: ESM can, as you know, import CJS. But, at least at the start, when using ESM here, it could not load JSON in that CJS. markdown-extensions was JSON, and failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

4 participants