Please provide a "close" for windows-in-windows

[bcsteeve]

For example, clicking "Choose Specific Download"... if there are lots of entries, the "popup window" (or whatever you call it) that lists the entries may take up the whole page. There is then no way to close that window or really do anything on that page without navigating back to home.

Kind of annoying and odd behavior.

I think it has to do with the top nav bar always being visible (which is kind of cool so not suggesting getting rid of that)

Suggest perhaps simply adding "close" button at bottom of the pop up window.

I use Chrome.

[basilfx]

I have added a fix for the specific example in the develop branch. Close buttons are already there, but they disappear behind the bar. I have limited the height, which should be a reasonable option IMHO.

[bcsteeve]

Sounds good to me. I'll test once it is in master.

[bcsteeve]

Sorry, thinking of the wrong project. I am on develop here. Tested. Works. Cheers.

It wouldn't be a horrible idea to implement same concept for "Choose Alternate Release". It is rare, but there has been a couple of times I've run into the same problem with an album that has a ridiculous number of releases.

[basilfx]

I have changed it a bit, and added the same for 'Choose Alternate Release'. Can you check it again?

[bcsteeve]

Did you commit it? I don't see an update from previous.

edit: n/m see it now. Checking.

[bcsteeve]

It works. If I can be nit-picky, it would be nice if the header (with the X) were a few pixels lower. It looks a bit weird and I've had to be really careful with my click to actually engage the X. But it works!

[basilfx]

Can you show me a screenshot of the problem?

[bcsteeve]

Interesting...

I was using my laptop as I usually do when dealing with music. The screen resolution is 1280_720 I believe. I was trying to get a screenshot for you including the mouse cursor (normal screen cap doesn't include cursor) when my wife kicked me out of the livingroom down to my office. I figured I'd continue the process here... but I just noticed on this pc I don't have the problem at all. The screen resolution of this monitor is 1920_1080. I'm guessing yours is also > 1280*720 and why you too aren't seeing my problem!

I can try again later to get you a screen cap on her monitor, but I think that's the issue... "low" resolution. Of course, it isn't really low. A web app should work with all common resolutions and tablets, for example, are going to be even lower.

I suggest making the code elastic relative to the screen resolution, by using em units rather than pixels or whatever it is using right now.

FYI: the reason I was trying to show the mouse in the screen cap is because it is more than just a cosmetic issue. At that resolution, yes the top of the title is cut off and a little bit of the X is too... but with the mouse pointed naturally at the center of the X... it won't click! You have to carefully position the mouse cursor at the bottom of the X and you only have a few pixels of wiggle room. It is awkward.

I wouldn't classify this as high-priority, by any means. It is only affecting a portion of users only a portion of the time... and then, it isn't completely unusable.