Skip to content

Conversation

sophiedeziel
Copy link
Collaborator

@sophiedeziel sophiedeziel commented Oct 13, 2024

Part of #221

Bringing back layer tolerance for z-axis movements and added configuration options for minimum layer threshold.

  • Added back minLayerThreshold option to the lib options
  • The option is passed to the Job
  • The job uses it to instantiate a layer indexer with tolerance
  • The layer indexer has a default tolerance of 0.05 (same as before)
  • The indexer uses that tolerance to split the layers based on z changes

@sophiedeziel
Copy link
Collaborator Author

sophiedeziel commented Oct 13, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiedeziel and the rest of your teammates on Graphite Graphite

@sophiedeziel sophiedeziel force-pushed the reintroduce-tolerance-for-layers branch from 871f16c to 4dae155 Compare October 14, 2024 00:08
@sophiedeziel sophiedeziel force-pushed the introduce-indexers branch 2 times, most recently from a75f06c to 678a96f Compare October 14, 2024 00:28
@sophiedeziel sophiedeziel force-pushed the reintroduce-tolerance-for-layers branch from 4dae155 to e7c4d8b Compare October 14, 2024 00:33
@sophiedeziel sophiedeziel force-pushed the introduce-indexers branch 2 times, most recently from 256595a to e32e879 Compare October 14, 2024 00:56
@sophiedeziel sophiedeziel force-pushed the reintroduce-tolerance-for-layers branch from e7c4d8b to 46e385b Compare October 14, 2024 00:57
@sophiedeziel sophiedeziel mentioned this pull request Oct 14, 2024
@sophiedeziel sophiedeziel reopened this Oct 14, 2024
@sophiedeziel sophiedeziel force-pushed the reintroduce-tolerance-for-layers branch from 46e385b to 57b62fe Compare October 14, 2024 01:35
@sophiedeziel sophiedeziel force-pushed the reintroduce-tolerance-for-layers branch from 57b62fe to 96dc517 Compare October 16, 2024 00:54
@sophiedeziel sophiedeziel marked this pull request as ready for review October 16, 2024 00:54
Base automatically changed from introduce-indexers to v3.x October 16, 2024 03:22
Copy link

github-actions bot commented Oct 16, 2024

Visit the preview URL for this PR (updated for commit 3b52aaf):

https://gcode-preview--pr224-reintroduce-toleranc-1jcvwxaa.web.app

(expires Fri, 15 Nov 2024 03:27:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 59bd114ae4847b32c2bba0b68620b9069a3e3531

@sophiedeziel sophiedeziel merged commit 954c813 into v3.x Oct 16, 2024
3 checks passed
@sophiedeziel sophiedeziel deleted the reintroduce-tolerance-for-layers branch October 16, 2024 03:32
sophiedeziel added a commit that referenced this pull request Oct 19, 2024
* Bring back the tolerance logic

* Simplify the options
sophiedeziel added a commit that referenced this pull request Oct 24, 2024
* Bring back the tolerance logic

* Simplify the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant