3033 fix GetRandom*

[akaspin]

trello

[dynamix]

having a single function and passing the slice makes sense 👍 but pickRandom seems to complicated. Check my proposal.

[dynamix]

This seems too complicated. Why not?

for l,r := from-1,from+1; l>=0||r<len(slice);l, r = l-1, r+1 {
	if r >= 0 && r < len(slice) && len(slice[r]) > 0 {
		return slice[r]
	}
	if l >= 0 && l < len(slice) && len(slice[l]) > 0 {
		return slice[r]
	}
}  

[akaspin]

2. Your approach was implemented first. BUT corrected behaviour always tries to pick random from l or r. This give more “randomness”.

hmmm. sec.

[dynamix]

Unlikely but what happens if r or l overflow?

[dynamix]

@akaspin an additional check won't hurt

[akaspin]

from can not be less or greater than length
l can not be greater than from-1
r can not be less than from+1

I'll make commit with tests and small improvements.