use_api accepts Procs #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added patch -procs to version number
|
This looks good. Could you remove the changed lines in |
added 3 commits
August 6, 2013 15:18
Added patch -procs to version number
|
Done. Sorry about that. |
|
It’s failing on ruby 1.8.7, we’ll have to use |
|
Changed that. |
| @@ -39,9 +39,13 @@ def use_api(value = nil) | |||
| superclass.use_api if superclass.respond_to?(:use_api) | |||
| end | |||
|
|
|||
| return @_her_use_api unless value | |||
| unless value | |||
| return (@_her_use_api.class == Proc) ? @_her_use_api.call : @_her_use_api | |||
There was a problem hiding this comment.
One last thing, instead of testing the class, I’d test if @_her_use_api responds to #call.
That’s it 😄
|
Still failing on 1.8.7 because of the new hash syntax. |
|
Sorry. I missed that bit. |
|
Thanks for your help! |
|
What is the eta on get this released to rubygems? |
|
/cc @remiprev |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a use case where we needed to use procs to dynamically set the api for uses_api based on model extensions. We added the code and test to do that. If you have a better idea we are completely open to suggestions.