Has many fetch collection check #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion from throwing an exception.
| # the response is nil. | ||
| unless collection.is_a?(Her::Collection) | ||
| for_collection = collection.attributes.empty? ? [] : collection | ||
| collection = Her::Collection.new(Array(for_collection)) |
There was a problem hiding this comment.
wouldn't it be better if this'd be done when calling super?
…fetch that the response should be a collection, instead of turning the response into a collection.
* master: Fix data cache on model for associations, fixes remi#248 Update README.md Conflicts: lib/her/model/associations/association.rb spec/model/associations_spec.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A get request that receives no data returns an instance. However, the fetch method has_many_association implicitly assumes it will receive a collection. When it instead receives an instance https://github.com/remiprev/her/blob/master/lib/her/model/associations/has_many_association.rb#L88
attempts to iterate over the instance and raises an exception.
This patch ensures that we always operate on a collection and allows delegated methods to work even when the response from the get request is blank. e.g. fixes #187