Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get when used for has_one relationships with active model serializers #394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix get when used for has_one relationships with active model serializers #394

wants to merge 2 commits into from

Commits on Jan 14, 2016

  1. Consider if we are grabbing has_one or has_many relations with active… 

    …_model_serializer.

When getting relations through has_one or has_many, we use Her::Model#get, not #get_resource which means
that we can't assume that the resource is a collection. it may well be a single resource via has_one
    @siassaj
    siassaj committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    4174837 View commit details
    Browse the repository at this point in the history

  2. Add specs for grabbing has_one associations with active_model_seriali… 

    …zer style apis
    @siassaj
    siassaj committed Jan 14, 2016
    Configuration menu
    Copy the full SHA
    1843933 View commit details
    Browse the repository at this point in the history