Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child classes can't set some attributes to false. #490

Merged
merged 1 commit into from
Mar 20, 2018

Conversation

zoltankiss
Copy link
Collaborator

Fixes: #488

cc @edtjones

@edtjones edtjones merged commit 1684f00 into remi:master Mar 20, 2018
@edtjones
Copy link
Collaborator

Terrific - thanks for this @zoltankiss - will do a release and push to rubygems ASAP.

@zoltankiss
Copy link
Collaborator Author

🎉!

@zoltankiss zoltankiss deleted the fix-include_root_in_json branch March 20, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants