Skip to content
This repository has been archived by the owner on Jun 13, 2019. It is now read-only.

Feature/make bubble head optional #43

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

k-thorat
Copy link
Contributor

@k-thorat k-thorat commented Oct 8, 2017

In this PR, I have added option to use Dotzu without Bubble Head and configure LogSettings programmatically.

Why?

  • We are using Dotzu with some in-house debugging tools. We were looking to manage all the debugging tools at one place.

Summary of changes:

  • Made LogSettings public and added var to track show/hide bubble head
  • Made Manager window & controller optional
  • Opened access to ManagerViewController from DotzuManager
  • Updated example with LogSettings

Notes:

  • Why Bubble head setting is not added to Dotzu Settings?
    ** I am working on another PR, which adds more options to LogSettings and it may get cumbersome to maintain.

Thanks a lot for your time.

Cheers!

@remirobert
Copy link
Owner

You have the same PR twice. Can you correct that before merging?
LGTM 💯

@k-thorat
Copy link
Contributor Author

Oops! I was working on two features and didn't switch branch :(

PR 44 has all my changes. Lets chat on PR 44.

@k-thorat
Copy link
Contributor Author

I think, I know why. PR 43 & 44 are connected. 44 is built on top of 43. That's why 44 showing same commits of 43. So, you can accept just 43 and not 44.

If you prefer to work on one PR in this case then I will close PR 43.

Please let me know if this makes sense.

@k-thorat
Copy link
Contributor Author

@Liman123 That's great. I am sure this is awesome tool. I have already got 4 messages from you. so please stop spamming my inbox.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants