This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
Remix has an object called
handle
onroute
see here for more info. If you pass a promise or a function to this object the service worker will fail with the following error:WHAT
We have added a function called
sanitizeHandleObject
to remove any promise or function from theroute.handle
.sanitizeHandleObject
is the function that is checking if theroute.handle
has any props that is either a function or a promise and if it has that, those will be removed from the object.