-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable v2_routeConvention
flag
#334
chore: enable v2_routeConvention
flag
#334
Conversation
a8c9917
to
bcbcf47
Compare
I think that was an old bug we fixed - I updated that example to I'm realizing most of our examples don't have v2 flags enabled 😬 . Not a v2 blocker but we'll want to get that handled after we release. At the moment we could probably update them all to 1.19.3? |
yep, that was the desired result of #172 so it didnt block any v2 and each example would be incrementally updated to future flags and subsequently v2 |
@brophdawg11 This is the first step towards enabling all of them, but didn't want to do 1 big PR for all v2 flags (other PRs are incoming as well) |
bf858f4
to
4fde61f
Compare
4fde61f
to
c30d7f2
Compare
@MichaelDeBoey yeah I agree one by one is the way to go. Should we update them all to |
@brophdawg11 I'll do it in a separate PR after merging this one |
@brophdawg11 Done in #337 |
Revival of @mcansh's #201
Got the same problem on the
pathless-routes
example though:⚠️ Route Path Collision: "/articles" The following routes all define the same URL, only the first one will be used 🟢 routes/articles._layout.tsx ⭕️️ routes/articles.tsx